Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Measurements from output permutation #96

Merged
merged 2 commits into from
May 2, 2022
Merged

✨ Measurements from output permutation #96

merged 2 commits into from
May 2, 2022

Conversation

burgholzer
Copy link
Member

This PR adds the functionality to add measurements according to the output permutation of a quantum circuit.
This is a first step towards realizing #35, in that it correctly conveys the expected output permutation in a standardized fashion.

Furthermore, this PR adds a convenience function to unify all quantum registers of a quantum circuit into a single register, which is useful for mapped circuits.

burgholzer added 2 commits May 2, 2022 12:59
…s according to output permutation

Signed-off-by: burgholzer <[email protected]>
@burgholzer burgholzer added the enhancement New feature or request label May 2, 2022
@burgholzer burgholzer requested a review from hillmich May 2, 2022 11:56
@burgholzer burgholzer self-assigned this May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #96 (070bfaf) into main (e13d0a8) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main     #96     +/-   ##
=======================================
+ Coverage   81.5%   81.7%   +0.1%     
=======================================
  Files         44      44             
  Lines       7144    7210     +66     
=======================================
+ Hits        5828    5894     +66     
  Misses      1316    1316             
Impacted Files Coverage Δ
include/QuantumComputation.hpp 88.8% <ø> (+<0.1%) ⬆️
src/QuantumComputation.cpp 65.2% <100.0%> (+0.8%) ⬆️
test/unittests/test_io.cpp 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13d0a8...070bfaf. Read the comment docs.

Copy link
Collaborator

@hillmich hillmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgholzer burgholzer enabled auto-merge (squash) May 2, 2022 12:18
@burgholzer burgholzer merged commit 674345f into main May 2, 2022
@burgholzer burgholzer deleted the measurements branch December 2, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants