Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Update CodeQL configuration #107

Merged
merged 8 commits into from
Sep 7, 2022
Merged

🔧 Update CodeQL configuration #107

merged 8 commits into from
Sep 7, 2022

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Sep 7, 2022

This PR updates the GitHub CodeQL configuration in anticipation of the deprecation of LGTM.
Most importantly, it adds further checks and a custom build step for C++ to also cover the Python bindings and the tests.
Finally, it also unifies and simplifies the whole configuration again.

By switching to the newer Ubuntu-22.04 runner, a recent enough Z3 version to build QMAP is available by default. This also allows the codeql-action/init action to properly build the Python package and (hopefully) provide better analysis.

The additional checks revealed a couple of tiny and easy to fix warnings/alerts that have subsequently been fixed.

@burgholzer burgholzer added github_actions Pull requests that update Github_actions code usability Anything related to usability continuous integration Anything related to the CI setup labels Sep 7, 2022
@burgholzer burgholzer self-assigned this Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.1%. Comparing base (96a3f29) to head (8ebfda7).
Report is 875 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #107   +/-   ##
=====================================
  Coverage   91.1%   91.1%           
=====================================
  Files         20      20           
  Lines       1726    1728    +2     
  Branches     411     411           
=====================================
+ Hits        1573    1575    +2     
  Misses       153     153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burgholzer burgholzer marked this pull request as ready for review September 7, 2022 18:49
@burgholzer burgholzer enabled auto-merge (squash) September 7, 2022 18:49
@burgholzer burgholzer disabled auto-merge September 7, 2022 19:14
@burgholzer
Copy link
Member Author

burgholzer commented Sep 7, 2022

For some reason, CI is taking crazy long now. Reverting the floating point comparison check.
Correction: Stupid mistake on my end... flipped the condition.

Signed-off-by: Lukas Burgholzer <[email protected]>
@burgholzer burgholzer merged commit 3269f51 into main Sep 7, 2022
@burgholzer burgholzer deleted the codeql-update branch September 7, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup github_actions Pull requests that update Github_actions code usability Anything related to usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant