-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Update CodeQL configuration #107
Conversation
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=====================================
Coverage 91.1% 91.1%
=====================================
Files 20 20
Lines 1726 1728 +2
Branches 411 411
=====================================
+ Hits 1573 1575 +2
Misses 153 153 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
For some reason, CI is taking crazy long now. Reverting the floating point comparison check. |
Signed-off-by: Lukas Burgholzer <[email protected]>
This PR updates the GitHub CodeQL configuration in anticipation of the deprecation of LGTM.
Most importantly, it adds further checks and a custom build step for C++ to also cover the Python bindings and the tests.
Finally, it also unifies and simplifies the whole configuration again.
By switching to the newer Ubuntu-22.04 runner, a recent enough Z3 version to build QMAP is available by default. This also allows the
codeql-action/init
action to properly build the Python package and (hopefully) provide better analysis.The additional checks revealed a couple of tiny and easy to fix warnings/alerts that have subsequently been fixed.