-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile issues #159
Fix compile issues #159
Conversation
Many thanks for these bugfixes! Could you please resolve the conflicts in this PR so that CI starts properly? The changes themselves look good to me. https://github.com/cda-tum/qmap/blob/main/docs/source/Installation.rst Would be great to change those as well. |
Furthermore, please merge the |
a5cb2b6
to
fe53ce9
Compare
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
=====================================
Coverage 91.8% 91.8%
=====================================
Files 24 24
Lines 2099 2099
Branches 414 414
=====================================
Hits 1927 1927
Misses 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The CI problems have been fixed now. Thank you for the pointer, it was really due to the fork being out of sync. Also changed the 2 mentions of CMAKE versions in the documentation, that I missed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks. Good to have these out of the way!
Description
find_package_check_version
)std::regex_match
withstd::regex_search
in the loading of coupling maps for a more lenient handling of white spaces in coupling map files