Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generatedNodes benchmark bug #411

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

EliasLF
Copy link
Collaborator

@EliasLF EliasLF commented Jan 5, 2024

Description

Fixing a minor bug, where sometimes the number of generated nodes is undercounted in the benchmark because nodes with equivalent layout are not added multiple times to the priority queue. Therefore, instead of relying on the size of the priority queue, it is more stable to rely on the node ids, which are strictly incremented for each generated node.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@EliasLF EliasLF added bug Something isn't working c++ Anything related to C++ code labels Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d17373) 93.0% compared to head (f84ee5c) 93.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #411     +/-   ##
=======================================
- Coverage   93.0%   93.0%   -0.1%     
=======================================
  Files         46      46             
  Lines       4946    4944      -2     
  Branches     852     852             
=======================================
- Hits        4604    4602      -2     
  Misses       342     342             
Flag Coverage Δ
cpp 92.7% <100.0%> (-0.1%) ⬇️
python 96.0% <ø> (ø)
Files Coverage Δ
src/heuristic/HeuristicMapper.cpp 94.1% <100.0%> (-0.1%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgholzer burgholzer merged commit 87d4502 into cda-tum:main Jan 5, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c++ Anything related to C++ code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants