Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iot1click): remove iot1click service resources as it got shut down #1559

Merged
merged 5 commits into from
Jan 11, 2025

Conversation

moelasmar
Copy link
Contributor

iot1click resource got shutdown, and we should stop generating the L1 constructs for this service.
Internal ticket P186779697

mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Jan 11, 2025
Removing the aws-iot1click package for the shut down service https://docs.aws.amazon.com/iot/latest/developerguide/iot-legacy-services.html
This PR is required to fix the Spec update PR cdklabs/awscdk-service-spec#1559

I updated the Spec2Cdk tool to accept extra parameter to maintain the list of services we want to skip generating them.

### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@moelasmar moelasmar closed this Jan 11, 2025
auto-merge was automatically disabled January 11, 2025 03:22

Pull request was closed

@moelasmar moelasmar reopened this Jan 11, 2025
Copy link

@aws-cdk/aws-service-spec: Model database diff detected

└[-] service aws-iot1click
  ├      capitalized: IoT1Click
  │      cloudFormationNamespace: AWS::IoT1Click
  │      name: aws-iot1click
  │      shortName: iot1click
  └ resources
     ├ resource AWS::IoT1Click::Device
     │ ├      name: Device
     │ │      cloudFormationType: AWS::IoT1Click::Device
     │ │      documentation: > AWS IoT 1-Click was discontinued on Dec 16, 2024. For more information, see [AWS IoT 1-Click](https://docs.aws.amazon.com//iot/latest/developerguide/iot-legacy-services.html) . 
     │ │      The `AWS::IoT1Click::Device` resource controls the enabled state of an AWS IoT 1-Click compatible device. For more information, see [Device](https://docs.aws.amazon.com/iot-1-click/1.0/devices-apireference/devices-deviceid.html) in the *AWS IoT 1-Click Devices API Reference* .
     │ ├ properties
     │ │  ├ DeviceId: string (required, immutable)
     │ │  └ Enabled: boolean (required)
     │ └ attributes
     │    ├ DeviceId: string
     │    ├ Enabled: boolean
     │    └ Arn: string
     ├ resource AWS::IoT1Click::Placement
     │ ├      name: Placement
     │ │      cloudFormationType: AWS::IoT1Click::Placement
     │ │      documentation: > AWS IoT 1-Click was discontinued on Dec 16, 2024. For more information, see [AWS IoT 1-Click](https://docs.aws.amazon.com//iot/latest/developerguide/iot-legacy-services.html) . 
     │ │      The `AWS::IoT1Click::Placement` resource creates a placement to be associated with an AWS IoT 1-Click project. A placement is an instance of a device in a location. For more information, see [Projects, Templates, and Placements](https://docs.aws.amazon.com/iot-1-click/latest/developerguide/1click-PTP.html) in the *AWS IoT 1-Click Developer Guide* .
     │ ├ properties
     │ │  ├ PlacementName: string (immutable)
     │ │  ├ ProjectName: string (required, immutable)
     │ │  ├ AssociatedDevices: json (immutable)
     │ │  └ Attributes: json
     │ └ attributes
     │    ├ PlacementName: string
     │    └ ProjectName: string
     └ resource AWS::IoT1Click::Project
       ├      name: Project
       │      cloudFormationType: AWS::IoT1Click::Project
       │      documentation: > AWS IoT 1-Click was discontinued on Dec 16, 2024. For more information, see [AWS IoT 1-Click](https://docs.aws.amazon.com//iot/latest/developerguide/iot-legacy-services.html) . 
       │      The `AWS::IoT1Click::Project` resource creates an empty project with a placement template. A project contains zero or more placements that adhere to the placement template defined in the project. For more information, see [CreateProject](https://docs.aws.amazon.com/iot-1-click/latest/projects-apireference/API_CreateProject.html) in the *AWS IoT 1-Click Projects API Reference* .
       ├ properties
       │  ├ Description: string
       │  ├ PlacementTemplate: PlacementTemplate (required)
       │  └ ProjectName: string (immutable)
       ├ attributes
       │  ├ ProjectName: string
       │  └ Arn: string
       └ types
          ├ type DeviceTemplate
          │ ├      name: DeviceTemplate
          │ └ properties
          │    ├ DeviceType: string
          │    └ CallbackOverrides: json
          └ type PlacementTemplate
            ├      documentation: > AWS IoT 1-Click was discontinued on Dec 16, 2024. For more information, see [AWS IoT 1-Click](https://docs.aws.amazon.com//iot/latest/developerguide/iot-legacy-services.html) . 
            │      In AWS CloudFormation , use the `PlacementTemplate` property type to define the template for an AWS IoT 1-Click project.
            │      `PlacementTemplate` is a property of the `AWS::IoT1Click::Project` resource.
            │      name: PlacementTemplate
            └ properties
               ├ DeviceTemplates: Map<string, DeviceTemplate> (immutable)
               └ DefaultAttributes: json

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jan 11, 2025
Merged via the queue into main with commit 7a31ca6 Jan 11, 2025
15 of 16 checks passed
@aws-cdk-automation aws-cdk-automation deleted the melasmar/iot1click branch January 11, 2025 03:41
iankhou pushed a commit to aws/aws-cdk that referenced this pull request Jan 13, 2025
Removing the aws-iot1click package for the shut down service https://docs.aws.amazon.com/iot/latest/developerguide/iot-legacy-services.html
This PR is required to fix the Spec update PR cdklabs/awscdk-service-spec#1559

I updated the Spec2Cdk tool to accept extra parameter to maintain the list of services we want to skip generating them.

### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants