Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32: TCP_MAXSEG isn't available for setsockopt #136

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

tbreeds
Copy link
Contributor

@tbreeds tbreeds commented Mar 9, 2017

According to [1,2] Windows platforms support getsockopt(TCP_MAXSSEG) but not setsockopt(TCP_MAXSEG) on IPPROTO_TCP sockets. This results in:

socket.error: [Errno 10042] An unknown, invalid, or unsupported option or level was specified in a getsockopt or setsockopt call

when trying to connect to the server.

This is a latent issue uncovered by the refactor in:
Set default KEEPIDLE/KEEPCNT/KEEPINTVL and TCP_USER_TIMEOUT (b14962c)

[1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms740476(v=vs.85).aspx
[2] https://msdn.microsoft.com/en-us/library/windows/desktop/ms738544(v=vs.85).aspx

@tbreeds
Copy link
Contributor Author

tbreeds commented Mar 9, 2017

Fixes #135

@BCLAU Can you check this works for you?

According to [1,2] Windows platforms support getsockopt(TCP_MAXSSEG) but not setsockopt(TCP_MAXSEG) on IPPROTO_TCP sockets.  This results in:

socket.error: [Errno 10042] An unknown, invalid, or unsupported option or level was specified in a getsockopt or setsockopt call

when trying to connect to the server.

This is a latent issue uncovered by the refactor in:
    Set default KEEPIDLE/KEEPCNT/KEEPINTVL and TCP_USER_TIMEOUT (b14962c)

[1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms740476(v=vs.85).aspx
[2] https://msdn.microsoft.com/en-us/library/windows/desktop/ms738544(v=vs.85).aspx
@codecov-io
Copy link

Codecov Report

Merging #136 into master will decrease coverage by -0.16%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   91.84%   91.69%   -0.16%     
==========================================
  Files          14       14              
  Lines        1644     1649       +5     
  Branches      224      226       +2     
==========================================
+ Hits         1510     1512       +2     
- Misses        106      107       +1     
- Partials       28       30       +2
Impacted Files Coverage Δ
amqp/platform.py 64.1% <33.33%> (-2.57%)
amqp/transport.py 71.71% <50%> (-0.18%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878dd8c...b17d41b. Read the comment docs.

@claudiubelu
Copy link

Sorry, for the delay.

Yep, thanks Tony, this looks fine: http://64.119.130.115/nova/442295/11/

@auvipy auvipy merged commit 9c6896d into celery:master Apr 13, 2017
@tbreeds
Copy link
Contributor Author

tbreeds commented Apr 13, 2017

\o/ Thanks!

@claudiubelu
Copy link

Thank you as well. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants