-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win32: TCP_MAXSEG isn't available for setsockopt #136
Conversation
According to [1,2] Windows platforms support getsockopt(TCP_MAXSSEG) but not setsockopt(TCP_MAXSEG) on IPPROTO_TCP sockets. This results in: socket.error: [Errno 10042] An unknown, invalid, or unsupported option or level was specified in a getsockopt or setsockopt call when trying to connect to the server. This is a latent issue uncovered by the refactor in: Set default KEEPIDLE/KEEPCNT/KEEPINTVL and TCP_USER_TIMEOUT (b14962c) [1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms740476(v=vs.85).aspx [2] https://msdn.microsoft.com/en-us/library/windows/desktop/ms738544(v=vs.85).aspx
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 91.84% 91.69% -0.16%
==========================================
Files 14 14
Lines 1644 1649 +5
Branches 224 226 +2
==========================================
+ Hits 1510 1512 +2
- Misses 106 107 +1
- Partials 28 30 +2
Continue to review full report at Codecov.
|
Sorry, for the delay. Yep, thanks Tony, this looks fine: http://64.119.130.115/nova/442295/11/ |
\o/ Thanks! |
Thank you as well. :D |
…SEG isn't available for setsockopt
According to [1,2] Windows platforms support getsockopt(TCP_MAXSSEG) but not setsockopt(TCP_MAXSEG) on IPPROTO_TCP sockets. This results in:
socket.error: [Errno 10042] An unknown, invalid, or unsupported option or level was specified in a getsockopt or setsockopt call
when trying to connect to the server.
This is a latent issue uncovered by the refactor in:
Set default KEEPIDLE/KEEPCNT/KEEPINTVL and TCP_USER_TIMEOUT (b14962c)
[1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms740476(v=vs.85).aspx
[2] https://msdn.microsoft.com/en-us/library/windows/desktop/ms738544(v=vs.85).aspx