Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo #4347

Merged
merged 11 commits into from
Feb 20, 2025
Merged

docs: fix typo #4347

merged 11 commits into from
Feb 20, 2025

Conversation

Bugarim
Copy link

@Bugarim Bugarim commented Feb 18, 2025

indicated - indicates
represent - represents

thanks devs

dependabot bot and others added 4 commits February 18, 2025 11:51
@dependabot
chore(deps): Bump github.com/ethereum/go-ethereum from 1.15.1 to 1.15…
b88ab42 
….2 (celestiaorg#4343)

Bumps
[github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum)
from 1.15.1 to 1.15.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/ethereum/go-ethereum/releases">github.com/ethereum/go-ethereum's
releases</a>.</em></p>
<blockquote>
<h2>Survivor Loadout (v1.15.2)</h2>
<p>This release fixes a few regressions. In particular, it restores
block building on mainnet, which was broken in v1.15.1.</p>
<p>All changes in this release:</p>
<ul>
<li>Block building on mainnet works again. (<a
href="https://redirect.github.com/ethereum/go-ethereum/pull/31191">#31191</a>)</li>
<li>Discv5 and DNS peer discovery has been restored. It was accidentally
disabled in v1.14.9. (<a
href="https://redirect.github.com/ethereum/go-ethereum/pull/31185">#31185</a>)</li>
<li>An edge-case for <code>geth dumpconfig</code> related to the
<code>P2P.NAT</code> setting in TOML is fixed. (<a
href="https://redirect.github.com/ethereum/go-ethereum/pull/31192">#31192</a>)</li>
</ul>
<p>For a full rundown of the changes please consult the Geth 1.15.2 <a
href="https://github.com/ethereum/go-ethereum/milestone/179?closed=1">release
milestone</a></p>
<hr />
<p>As with all our previous releases, you can find the:</p>
<ul>
<li>Pre-built binaries for all platforms on our <a
href="https://geth.ethereum.org/downloads/">downloads page</a>.</li>
<li>Docker images published under <a
href="https://cloud.docker.com/u/ethereum/repository/docker/ethereum/client-go"><code>ethereum/client-go</code></a>.</li>
<li>Ubuntu packages in our <a
href="https://launchpad.net/~ethereum/+archive/ubuntu/ethereum">Launchpad
PPA repository</a>.</li>
<li>OSX packages in our <a
href="https://github.com/ethereum/homebrew-ethereum">Homebrew Tap
repository</a>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/ethereum/go-ethereum/commit/c8c62dafc78b0edadfa9406503cef2d957299f8b"><code>c8c62da</code></a>
version: release go-ethereum v1.15.2 stable</li>
<li><a
href="https://github.com/ethereum/go-ethereum/commit/d37a0b8cd0ad799dd696c25249987d89394a1409"><code>d37a0b8</code></a>
eth/protocols/eth: add discovery iterator to protocol (<a
href="https://redirect.github.com/ethereum/go-ethereum/issues/31185">#31185</a>)</li>
<li><a
href="https://github.com/ethereum/go-ethereum/commit/c113e3b5b12619c80b962a3b6e895a14a13eaa75"><code>c113e3b</code></a>
p2p: fix marshaling of NAT in TOML (<a
href="https://redirect.github.com/ethereum/go-ethereum/issues/31192">#31192</a>)</li>
<li><a
href="https://github.com/ethereum/go-ethereum/commit/e5bc789185e74a776d122b95e490639068a6a612"><code>e5bc789</code></a>
consensus/beacon: fix isPostMerge for mainnet (<a
href="https://redirect.github.com/ethereum/go-ethereum/issues/31191">#31191</a>)</li>
<li><a
href="https://github.com/ethereum/go-ethereum/commit/68de26e34649e50c1f8f8a858a686c38274848b6"><code>68de26e</code></a>
core/types: create block's bloom by merging receipts' bloom (<a
href="https://redirect.github.com/ethereum/go-ethereum/issues/31129">#31129</a>)</li>
<li><a
href="https://github.com/ethereum/go-ethereum/commit/77762820c9d1ec6cc33ab97ede61861772011756"><code>7776282</code></a>
version: begin v1.15.2 release cycle</li>
<li>See full diff in <a
href="https://github.com/ethereum/go-ethereum/compare/v1.15.1...v1.15.2">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/ethereum/go-ethereum&package-manager=go_modules&previous-version=1.15.1&new-version=1.15.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rootulp
revert: default mempool to prioritized (v1) (celestiaorg#4344)
733419e 
We got reports from @mindstyle85 that the v2 mempool caused issues for
users so we're reverting the default back to the prioritized mempool v1.
@Bugarim
Update tx.pb.go
2c1c655
@Bugarim
Update manager.go
cc8d484
@Bugarim Bugarim requested a review from a team as a code owner February 18, 2025 23:49
@Bugarim Bugarim requested review from cmwaters and ninabarbakadze and removed request for a team February 18, 2025 23:49
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2025

📝 Walkthrough

Walkthrough

This pull request applies a minor change to a comment within the Manager struct in the app/module/manager.go file. The update corrects the grammar of the comment describing the uniqueModuleVersions field by changing "represent" to "represents." No modifications were made to the code's functionality, logic, or error-handling.

Changes

File(s) Changes
app/module/manager.go Corrected a grammatical error in the comment for the uniqueModuleVersions field in the Manager struct.

Suggested labels

external

Suggested reviewers

  • cmwaters
  • evan-forbes
  • rootulp
  • ninabarbakadze
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 733419e and cc8d484.

⛔ Files ignored due to path filters (1)
  • app/grpc/tx/tx.pb.go is excluded by !**/*.pb.go
📒 Files selected for processing (1)
  • app/module/manager.go (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • app/module/manager.go
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

rach-id
rach-id requested changes Feb 19, 2025
View reviewed changes
@rach-id rach-id changed the base branch from main to typos February 19, 2025 08:03
@rootulp rootulp marked this pull request as draft February 19, 2025 08:46
@rach-id
Copy link
Member

rach-id commented Feb 19, 2025

@Bugarim fix the PR title to follow the conventional commits spec https://www.conventionalcommits.org/en/v1.0.0/ .

@Bugarim Bugarim changed the title correction comments docs: fix typo Feb 20, 2025
@Bugarim
Copy link
Author

Bugarim commented Feb 20, 2025

@rach-id thanks ! i did it

@rach-id
Copy link
Member

rach-id commented Feb 20, 2025

fix the commit history

@rootulp
Copy link
Collaborator

rootulp commented Feb 20, 2025 •
edited
Loading

@rach-id I think we need to update the the typos branch with the latest change from main so that they don't appear in this diff.

Update: tried in #4349 but doesn't appear to have resolved.

@Bugarim
Copy link
Author

Bugarim commented Feb 20, 2025

@rach-id +++ , ready

@rach-id rach-id marked this pull request as ready for review February 20, 2025 12:39
@rach-id rach-id merged commit d520834 into celestiaorg:typos Feb 20, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id requested changes

@cmwaters cmwaters Awaiting requested review from cmwaters cmwaters is a code owner automatically assigned from celestiaorg/celestia-core

@ninabarbakadze ninabarbakadze Awaiting requested review from ninabarbakadze ninabarbakadze is a code owner automatically assigned from celestiaorg/celestia-core

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

@rootulp rootulp Awaiting requested review from rootulp

Assignees
No one assigned
Labels
external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bugarim @rach-id @rootulp