You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Are they necessary? A cursory search shows that these exported functions aren't used in celestia-core, celestia-app, or celestia-node so if not consider removing them
The text was updated successfully, but these errors were encountered:
* Add `CMT_HOME` (or remove it?) (#983)
Closes#982
Added `CMT_HOME` everywhere `CMTHOME` is used.
### Notes to reviewers
This could be fixed the opposite way, by removing the only reference to `CMT_HOME` in the code, and also the reference in `UPGRADING.md` (two lines of code).
However, the reference in `UPGRADING.md`, which is part of our documentation, is already present in `v0.34.x` (not in `v0.37.x` though!). That's why this PR introduces `CMT_HOME` to work in equal conditions as `CMTHOME`.
If reviewers lean toward removing `CMT_HOME` from the doc in `v0.34.x` (and unreleased `v0.38.x` and `main`), I can do it easily.
---
#### PR checklist
- [x] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
(cherry picked from commit b7be568)
# Conflicts:
# cmd/cometbft/commands/root_test.go
* Revert "Add `CMT_HOME` (or remove it?) (#983)"
* Add `CMT_HOME` (or remove it?) (#983)
Closes#982
Added `CMT_HOME` everywhere `CMTHOME` is used.
This could be fixed the opposite way, by removing the only reference to `CMT_HOME` in the code, and also the reference in `UPGRADING.md` (two lines of code).
However, the reference in `UPGRADING.md`, which is part of our documentation, is already present in `v0.34.x` (not in `v0.37.x` though!). That's why this PR introduces `CMT_HOME` to work in equal conditions as `CMTHOME`.
If reviewers lean toward removing `CMT_HOME` from the doc in `v0.34.x` (and unreleased `v0.38.x` and `main`), I can do it easily.
---
- [x] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
---------
Co-authored-by: Sergio Mena <[email protected]>
Context
celestia-core/types/block.go
Lines 1081 to 1103 in f7b5c1f
Questions
The text was updated successfully, but these errors were encountered: