refactor: add miss stop ticker #1222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoanguyenkh
commented
Feb 12, 2024
hoanguyenkh
commented
- add miss stop ticker
- replace ticker with time.After(X)
hoanguyenkh
requested review from
evan-forbes,
cmwaters,
staheri14,
rach-id,
ninabarbakadze and
rootulp
as code owners
evan-forbes
reviewed
Feb 12, 2024
There was a problem hiding this comment.
thanks for this @hoanguyenkh! while we good just take these changes in, imo since they're not of immediate concern and could be applied to all comet chains, I think it makes sense to upstream this change
thanks for feedback, i think upstream this change is good choice |
|
Sounds good. We can close this PR here and pull this change from upstream once it is implemented. |
rootulp
pushed a commit
to rootulp/celestia-core
that referenced
this pull request
Sep 20, 2024
…elestiaorg#1079) (celestiaorg#1222) * Log proposer's address when correctly accepting a proposal (celestiaorg#1079) * Log proposer when logging received proposal * Addressed review comments * Promote updates to validator to Info level (cherry picked from commit cf23082) # Conflicts: # consensus/state.go # state/execution.go * Revert "Log proposer's address when correctly accepting a proposal (celestiaorg#1079)" This reverts commit 8ccdb00e9023da91ae324c86956ffe5a5851d1a3. * Log proposer's address when correctly accepting a proposal (celestiaorg#1079) * Log proposer when logging received proposal * Addressed review comments * Promote updates to validator to Info level --------- Co-authored-by: Sergio Mena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.