Add messages when converting to protobuf version of block data #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
liamsi,
tzdybal and
Wondertan
and removed request for
tac0turtle
Wondertan
approved these changes
Nov 17, 2021
types/block.go
Outdated
Comment on lines
1258
to
1268
| // need to add messages | ||
| protoMsgs := make([]*tmproto.Message, len(data.Messages.MessagesList)) | ||
| for i, msg := range data.Messages.MessagesList { | ||
| protoMsgs[i] = &tmproto.Message{ | ||
| NamespaceId: msg.NamespaceID, | ||
| Data: msg.Data, | ||
| } | ||
| } | ||
| tp.Messages = tmproto.Messages{MessagesList: protoMsgs} | ||
|
|
||
| return *tp |
There was a problem hiding this comment.
Yeaah, you found it. Congrats. LGTM
adlerjohn
reviewed
Nov 18, 2021
liamsi
approved these changes
Nov 18, 2021
evan-forbes
added a commit
that referenced
this pull request
Apr 28, 2022
* export parsing functions * add messages to proto version of data * remove redundant test * remove redundant test
evan-forbes
added a commit
that referenced
this pull request
May 3, 2022
* export parsing functions * add messages to proto version of data * remove redundant test * remove redundant test
evan-forbes
added a commit
that referenced
this pull request
May 3, 2022
Add messages when converting to protobuf version of block data (#580) * export parsing functions * add messages to proto version of data * remove redundant test * remove redundant test
evan-forbes
added a commit
that referenced
this pull request
May 3, 2022
Add messages when converting to protobuf version of block data (#580) * export parsing functions * add messages to proto version of data * remove redundant test * remove redundant test
williambanfield
pushed a commit
to interchainio/celestia-core
that referenced
this pull request
Jul 14, 2022
Add messages when converting to protobuf version of block data (celestiaorg#580) * export parsing functions * add messages to proto version of data * remove redundant test * remove redundant test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is needed to properly submit messages, and fixes the "bug" where the chain halts after submitting a signed pay for message.