protobuf decode tx patch #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
reviewed
Nov 20, 2021
liamsi
approved these changes
Nov 20, 2021
types/tx.go
Outdated
| func DecodeChildTx(tx Tx) (hash []byte, unwrapped Tx, has bool) { | ||
| // attempt to unmarshal into a a child transaction | ||
| var childTx tmproto.ChildTx | ||
| err := proto.Unmarshal(tx, &childTx) | ||
| if err != nil { | ||
| return nil, nil, false | ||
| } | ||
| // this check isn't fool proof but it should work most of the time | ||
| if len(childTx.ParentTxHash) != sha256.Size { |
There was a problem hiding this comment.
Isn't there like a constant in the code that references this already? Just in case we swap out the hash function in the future then we won't have to change many places.
There was a problem hiding this comment.
good idea, switched to using the hash size from tmhash
af691ce
Co-authored-by: John Adler <[email protected]>
evan-forbes
added a commit
that referenced
this pull request
Apr 26, 2022
* fix protobuf bug * clean up * mispelling * add more comments to a weird test * Update types/tx.go Co-authored-by: John Adler <[email protected]> * better comment w/ todo and use prexisting hash constant Co-authored-by: John Adler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I didn't know protobuf doesn't check types when unmarshalling, so there needs to be some check to prevent random stuff from being returned successfully from
DecodeChildTx