Add an RPC endpoint for DataCommitment #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
changed the title
adlerjohn
reviewed
Feb 3, 2022
Co-authored-by: John Adler <[email protected]>
Co-authored-by: John Adler <[email protected]>
Co-authored-by: John Adler <[email protected]>
evan-forbes
previously approved these changes
Feb 4, 2022
|
@evan-forbes @adlerjohn What should be the response for an empty block set ? |
yeah, we should definitely try to return an error in that case, either using a client side check or via the server. but this is optional imho, as we can add this check when implementing the relayer |
|
@evan-forbes added the sanity check. If it looks good, we can merge :D |
evan-forbes
reviewed
Feb 4, 2022
evan-forbes
dismissed
their stale review
need to move constant to the consts package
|
ahh I see, nice! |
evan-forbes
approved these changes
Feb 4, 2022
evan-forbes
pushed a commit
that referenced
this pull request
Apr 29, 2022
* init adding DataCommitment rpc * updates data commitment json response name * fix import * Update rpc/client/interface.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * lint * adds test for data commitment (still not working) * fixes data commitment creation * fixes data commitment test * adds data commitment RPC test * update comment * updates openapi specs * add blocks sanity check for data commitment * rename blockByQuery to heightsByQuery to reflect more what the function is doing * moves DataCommitmentBlocksLimit to consts * adds tests for data commitment limits Co-authored-by: John Adler <[email protected]>
evan-forbes
pushed a commit
that referenced
this pull request
May 3, 2022
* init adding DataCommitment rpc * updates data commitment json response name * fix import * Update rpc/client/interface.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * lint * adds test for data commitment (still not working) * fixes data commitment creation * fixes data commitment test * adds data commitment RPC test * update comment * updates openapi specs * add blocks sanity check for data commitment * rename blockByQuery to heightsByQuery to reflect more what the function is doing * moves DataCommitmentBlocksLimit to consts * adds tests for data commitment limits Co-authored-by: John Adler <[email protected]> run make mockery patch compute shares for pkg files finish remaining rpc refactor
evan-forbes
pushed a commit
that referenced
this pull request
May 3, 2022
* init adding DataCommitment rpc * updates data commitment json response name * fix import * Update rpc/client/interface.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * lint * adds test for data commitment (still not working) * fixes data commitment creation * fixes data commitment test * adds data commitment RPC test * update comment * updates openapi specs * add blocks sanity check for data commitment * rename blockByQuery to heightsByQuery to reflect more what the function is doing * moves DataCommitmentBlocksLimit to consts * adds tests for data commitment limits Co-authored-by: John Adler <[email protected]> run make mockery patch compute shares for pkg files finish remaining rpc refactor
evan-forbes
pushed a commit
that referenced
this pull request
May 3, 2022
* init adding DataCommitment rpc * updates data commitment json response name * fix import * Update rpc/client/interface.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * lint * adds test for data commitment (still not working) * fixes data commitment creation * fixes data commitment test * adds data commitment RPC test * update comment * updates openapi specs * add blocks sanity check for data commitment * rename blockByQuery to heightsByQuery to reflect more what the function is doing * moves DataCommitmentBlocksLimit to consts * adds tests for data commitment limits Co-authored-by: John Adler <[email protected]> run make mockery patch compute shares for pkg files finish remaining rpc refactor
williambanfield
pushed a commit
to interchainio/celestia-core
that referenced
this pull request
Jul 14, 2022
* init adding DataCommitment rpc * updates data commitment json response name * fix import * Update rpc/client/interface.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * Update rpc/core/blocks.go Co-authored-by: John Adler <[email protected]> * lint * adds test for data commitment (still not working) * fixes data commitment creation * fixes data commitment test * adds data commitment RPC test * update comment * updates openapi specs * add blocks sanity check for data commitment * rename blockByQuery to heightsByQuery to reflect more what the function is doing * moves DataCommitmentBlocksLimit to consts * adds tests for data commitment limits Co-authored-by: John Adler <[email protected]> run make mockery patch compute shares for pkg files finish remaining rpc refactor
Magkoooh
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
DataCommitmentRPC endpoint to be used to calculate the merkle root of a set of data roots.Closes: #620