Fixed the aggressive eviction of txns in txn pool #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcortesi
approved these changes
Aug 31, 2020
kevjue
deleted the
kevjue/cherry_pick_geth_upstream_6793ffa12b7d4e86ee2f66afa1647dd3f0680ea0
branch
gastonponti
added a commit
that referenced
this pull request
Jun 18, 2021
Description Merge from upstream, go-ethereum v1.9.18 a bugfix release 1.9.18 notes from our changes: 1059221/queue.go -> reserveHeaders: changed to force as a pending for bodyTypes reserves (even if the block has an empty body, we have to retrieve it to update the random beacon tx_pool_test.go testTransactionQueueTimeLimiting kept the test as we had, because it was already cherrypicked and changed before (#1149) subsequent commits left the same as the cherrypicked before (5413df1, 6793ffa) Tested Unit and integration tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a cherry pick merge of this geth upstream PR: ethereum/go-ethereum#21300
During load tests, we saw that txns were being very aggressively evicted from the txpool (in some cases evicted within a second of being added to it). This caused the submitted txn to never be propagated throughout the network. Also, based on how our load tests are designed, this bug was preventing us to saturate the block chain.
After making this change, our load tests are able to saturate the block chain.
Testing
As part of the original upstream PR, there are unit tests that verify that txns are not evicted early. Also, our load tests is able to confirm that the txns are not evicted early (and hence can saturate the chain).
Backwards compatibility
Is backwards compatible