-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r] add remaining API demo vignettes #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
title: "Axis Query Example" | ||
output: rmarkdown::html_vignette | ||
vignette: > | ||
%\VignetteIndexEntry{census_axis_query} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field should match the title, otherwise pkgdown will complain and generate a warning.
cat(paste( | ||
"There are", | ||
length(unique_cell_type_ontology_term_id), | ||
"cell types in the Cell Census! The first few are:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"cell types in the Cell Census! The first few are:" | |
"cell types in the Census! The first few are:" |
cat(paste( | ||
"There are ", | ||
length(unique_cell_type_ontology_term_id), | ||
" cell types in the Cell Census where tissue_ontology_term_id == ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" cell types in the Cell Census where tissue_ontology_term_id == ", | |
" cell types in the Census where tissue_ontology_term_id == ", |
furthers #248. Compbio notebooks are still pending. Also, working through
census_dataset_presence
triggered a deep dive on R's inherent one-based indexing, how to mesh that with some of the zero-based concepts in SOMA currently -- will make follow-up PRs as appropriate.