Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] add remaining API demo vignettes #358

Merged
merged 15 commits into from
Apr 17, 2023
Merged

Conversation

mlin
Copy link
Contributor

@mlin mlin commented Apr 6, 2023

furthers #248. Compbio notebooks are still pending. Also, working through census_dataset_presence triggered a deep dive on R's inherent one-based indexing, how to mesh that with some of the zero-based concepts in SOMA currently -- will make follow-up PRs as appropriate.

@mlin mlin marked this pull request as ready for review April 10, 2023 04:24
Copy link
Contributor

@pablo-gar pablo-gar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

title: "Axis Query Example"
output: rmarkdown::html_vignette
vignette: >
%\VignetteIndexEntry{census_axis_query}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field should match the title, otherwise pkgdown will complain and generate a warning.

cat(paste(
"There are",
length(unique_cell_type_ontology_term_id),
"cell types in the Cell Census! The first few are:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"cell types in the Cell Census! The first few are:"
"cell types in the Census! The first few are:"

cat(paste(
"There are ",
length(unique_cell_type_ontology_term_id),
" cell types in the Cell Census where tissue_ontology_term_id == ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
" cell types in the Cell Census where tissue_ontology_term_id == ",
" cell types in the Census where tissue_ontology_term_id == ",

@mlin mlin merged commit 1307c74 into main Apr 17, 2023
@mlin mlin deleted the mlin/r-vignette-census-axis-query branch April 17, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants