Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total installs to search result + sort #1029

Merged
merged 10 commits into from
May 25, 2023
Merged

Conversation

codemonkey800
Copy link
Collaborator

Description

#706 #707

  • Adds total installs count to search result
  • Adds total installs sort option

Demos

Total installs on search result

image

Total installs sort

image

@codemonkey800 codemonkey800 added the new-feature Release Label: Used for categorizing features in automated release notes label May 5, 2023
@codemonkey800 codemonkey800 requested review from manasaV3 and klai95 May 5, 2023 15:36
@codemonkey800
Copy link
Collaborator Author

E2E tests are failing for some reason. Might be because we removed Version from the search results or maybe it could be because we added a new sort option to the dropdown 🤔

@codemonkey800 codemonkey800 force-pushed the jeremy/total-installs-ui branch from c023410 to 7bc0860 Compare May 19, 2023 21:56
@@ -175,4 +179,16 @@ describe('sortResults()', () => {
expected: ['napari-b', 'napari-a', 'napari-c', 'napari-d'],
});
});

it('should sort by total installs', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codemonkey800 codemonkey800 merged commit b9d4199 into main May 25, 2023
@codemonkey800 codemonkey800 deleted the jeremy/total-installs-ui branch May 25, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Release Label: Used for categorizing features in automated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants