Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home page cards setup #1074

Closed
wants to merge 5 commits into from
Closed

Home page cards setup #1074

wants to merge 5 commits into from

Conversation

codemonkey800
Copy link
Collaborator

Description

#1008

This PR adds refactors and new code for the implementation of the plugin sections UI for the home page redesign.

  • Clean up typing modules:
    • Re-organizes our src/types directory to use src/types/index.ts as the main export file. This also adds the new files src/types/utils.ts and src/types/plugin.ts
  • Add home page types:
    • Adds typing for the home page API response based on the API contract
  • Add i18n / icons:
    • Adds new copy and components for use in the home page
  • Add FE generated plugin sections:
    • Adds getPluginSections() function for getting plugin sections API data. This is currently uses FE generated sections to mock the response, but will eventually be replaced with the actual backend API call in Integrate frontend with plugin sections API #1036

@codemonkey800 codemonkey800 added the maintenance Release Label: Used for categorizing maintenance PRs in automated CI release notes label May 25, 2023
@codemonkey800 codemonkey800 marked this pull request as ready for review May 25, 2023 23:27
@richaagarwal richaagarwal removed their request for review June 1, 2023 22:00
@codemonkey800 codemonkey800 changed the title Home page cards setup Home page cards redesign Jun 7, 2023
@codemonkey800 codemonkey800 changed the title Home page cards redesign Home page redesign Jun 7, 2023
@codemonkey800 codemonkey800 changed the title Home page redesign Home page cards setup Jun 7, 2023
@codemonkey800 codemonkey800 force-pushed the jeremy/home-page-cards-setup branch from 2d2a9f3 to 9affffe Compare June 7, 2023 21:40
@codemonkey800 codemonkey800 mentioned this pull request Jun 13, 2023
Merged
@codemonkey800
Copy link
Collaborator Author

close in favor of #1107

@codemonkey800 codemonkey800 deleted the jeremy/home-page-cards-setup branch June 21, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manasaV3 manasaV3 manasaV3 approved these changes

@kne42 kne42 Awaiting requested review from kne42

Assignees
No one assigned
Labels
maintenance Release Label: Used for categorizing maintenance PRs in automated CI release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codemonkey800 @manasaV3