Rename client/ to frontend/ #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
force-pushed
the
jeremy/rename-client-to-frontend
branch
from
f67063f to
5f9ece0
Compare
|
I tried to access the link you posted to the test env, but I'm getting a 503 error 😬 |
|
@justinelarsen Maybe try hard refreshing or accessing in incognito? It's working on my end 😢 If it doesn't work then I'll do a bit more investigation |
|
@codemonkey800 Yes, that worked! Interesting.... 🤔 |
justinelarsen
approved these changes
Jul 2, 2021
|
@justinelarsen the test deployment should be enough verification that things will work correctly for prod deployments 😄 |
|
@justinelarsen I'll monitor the staging deployment after merging. If anything prevents the website from working functionally, I'll do a revert of the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is something I've been wanting to do for a while to be consistent with the naming for the backend, but I wanted to wait until after the release since we were blasting out features the past few months.
This is a big change so it'd be great to merge this as soon as possible to reduce future merge conflicts.
Demo
I deployed a stack to demonstrate that the deployment works even after the renaming.
https://dev-rename-client-to-frontend-frontend.dev.imaging.cziscience.com/