Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing requirements throwing server error #209

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

codemonkey800
Copy link
Collaborator

@codemonkey800 codemonkey800 commented Jul 15, 2021

Description

Closes #208

The requirements array can be returned either as null or '' when empty, but the code is written with the assumption it's always an array.

Demo

https://fix-reqs-frontend.dev.imaging.cziscience.com/plugins/napari-clemreg

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #148021: Fix P0 bugs.

@justinelarsen
Copy link
Contributor

@codemonkey800 I'm getting a "503 Service Temporarily Unavailable" error when trying to go to the demo link.

Copy link
Contributor

@justinelarsen justinelarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kne42 kne42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codemonkey800 codemonkey800 merged commit 45d452a into main Jul 26, 2021
@codemonkey800 codemonkey800 deleted the jeremyasuncion/ch148021/fix-missing-reqs branch July 26, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins without requirements throw a server error
3 participants