-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collections page UI #521
Collections page UI #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really great! There are just a couple of small things I noticed to change:
- the vertical spacing surrounding the "Collections" page title should be equal above it and below it; right now it looks like it is larger below (I think because of line-height of the texts maybe, it is creating a larger gap?)
- the vertical spacing between the bottom of the very last of the listed collections and the top of the footer should be 75px (for all pages except if there's pagination, it has it's own spacing)
- the line height of the text should be 1.5, so for the short description per collection with type size 14px, it should be 21px, but it's currently at 125% (~17.5px)
Thanks, and let me know if any questions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breakpoints are off and resizing the window is laggy on narrower screens, but as long as we can address those issues before release, happy to see this merged :D
@liaprins-czi could you review again pls and check if above issues are fixed? thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything I noted originally (including breakpoint issue) is now fixed; looks good to me!
*/ | ||
export function CollectionCard({ collection }: Props) { | ||
return ( | ||
<Link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How feasible would it be to move these into CSS rules in a separate file? e.g. having specific styling defined for a collection card, collection button, etc. Not sure if that is part of the "Extract this to design system" work or if there are other reasons not to do this, but might be worth considering to separate concerns & perhaps enable designers to more easily make updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh so for frontend we support both Tailwind and SCSS. Right now approach we're following is always use Tailwind and then SCSS if not possible. This helps us keep the resulting CSS bundle small and helps with building UIs fast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, we do have a growing need to share certain styles from a design system. We're working with the SDS (Science Design System) team right now to get that going but it's out of scope for this PR 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codemonkey800 Sounds good! I'm not too familiar with Tailwind so would love an overview of how that works some time, but definitely not a blocker or pressing need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, happy to give an overview of the frontend tech on the hub 😄
0fee47c
to
840a61b
Compare
Closes #510
Demo
https://napari-hub-collections-page.vercel.app/collections