Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused activity components #774

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Conversation

manasaV3
Copy link
Collaborator

@manasaV3 manasaV3 commented Nov 29, 2022

Relates to:

#720
#775

Summary

Removes the code for individual activity APIs as the frontend uses the consolidated/metric endpoint as of #749

Also, removes totalMonths in the metric endpoint response as a part of #775

klai95
klai95 previously approved these changes Nov 29, 2022
codemonkey800
codemonkey800 previously approved these changes Nov 29, 2022
@codemonkey800 codemonkey800 added the improvement Release Label: Used for categorizing improvements in automated CI release notes label Nov 29, 2022
@richaagarwal
Copy link
Collaborator

Could you update the PR title to something more descriptive before merging? It makes release notes and the commit history easier to follow :)

@manasaV3 manasaV3 changed the title unused old components Removing activity endpoints that are not used Nov 30, 2022
richaagarwal
richaagarwal previously approved these changes Nov 30, 2022
@manasaV3 manasaV3 dismissed stale reviews from richaagarwal, codemonkey800, and klai95 via 0dd61e8 November 30, 2022 21:38
@manasaV3 manasaV3 changed the title Removing activity endpoints that are not used Removing unused activity components Nov 30, 2022
@manasaV3
Copy link
Collaborator Author

Could you update the PR title to something more descriptive before merging? It makes release notes and the commit history easier to follow

Thanks for catching that. Not sure how the initial title even came to be. 😅

@klai95
Copy link
Contributor

klai95 commented Nov 30, 2022

Relates to:

#720 #775

Summary

Removes the code for individual activity APIs as the frontend uses the consolidated/metric endpoint as of #749

Also, removes totalMonths in the metric endpoint response.

Could we provide the context for removing totalMonths in this ticket? i.e.: Since the team has decided to use the release date metric instead, totalMonths is no longer needed.

@manasaV3
Copy link
Collaborator Author

Relates to:

#720 #775

Summary

Removes the code for individual activity APIs as the frontend uses the consolidated/metric endpoint as of #749
Also, removes totalMonths in the metric endpoint response.

Could we provide the context for removing totalMonths in this ticket? i.e.: Since the team has decided to use the release date metric instead, totalMonths is no longer needed.

Good call, I have linked the related issue to it.

klai95
klai95 previously approved these changes Nov 30, 2022
Copy link
Contributor

@klai95 klai95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@manasaV3 manasaV3 added the clean-up This references any clean up work that is needed post feature development label Nov 30, 2022
@manasaV3 manasaV3 merged commit 124c2c4 into main Dec 6, 2022
@manasaV3 manasaV3 deleted the metric-activity-cleanup branch December 6, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up This references any clean up work that is needed post feature development improvement Release Label: Used for categorizing improvements in automated CI release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants