Handling case-sensitivity in plugin name for activity #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manasaV3
added
the
bug-fix
codemonkey800
approved these changes
Dec 6, 2022
klai95
reviewed
Dec 6, 2022
| mock_df = pd.DataFrame({'MONTH': pd.to_datetime(date_list), 'NUM_DOWNLOADS_BY_MONTH': mock_installs}) | ||
| empty_df = pd.DataFrame(columns=['MONTH', 'NUM_DOWNLOADS_BY_MONTH']) | ||
| mock_plugin_recent_installs = {'string-1': 25, 'foo': 10, 'bar': 30} | ||
| BASE = datetime.today().date().replace(day=1) |
There was a problem hiding this comment.
Just for some context, what is the reason behind naming all variables in caps?
There was a problem hiding this comment.
The python convention for marking a variable to be constant is to name it in uppercase. As all those variables should be treated as constants, I updated their name to reflect the convention.
klai95
approved these changes
Dec 6, 2022
richaagarwal
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #785
Summary
We transform the plugin name used for querying against data to lowercase to fix the issue. To ensure consistency, we also convert the plugin name to lowercase when we fetch and save the data.