Send dynamo feature flag from frontend #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
added
the
new-feature
klai95
previously approved these changes
Mar 25, 2023
manasaV3
approved these changes
Mar 30, 2023
klai95
approved these changes
Mar 30, 2023
manasaV3
reviewed
Apr 5, 2023
| const { data } = await this.api.get<PluginIndexData[]>('/plugins/index'); | ||
| const data = await this.sendRequest<PluginIndexData[]>('/plugins/index', { | ||
| params: { | ||
| use_use_dynamo_plugin: this.dynamoConfig.PLUGIN_MIGRATION, |
There was a problem hiding this comment.
This should be use_dynamo_plugin.
| `/plugins/${name}`, | ||
| { | ||
| params: { | ||
| use_use_dynamo_plugin: this.dynamoConfig.PLUGIN_MIGRATION, |
There was a problem hiding this comment.
This should be use_dynamo_plugin.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#869
Sends dynamo query parameters described in #869 (comment) based on dynamo feature flag configuration value.
Demos
Plugin Index
Plugin
Metrics