Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Make it possible to use page.keyboard.type('text') instead of page.ty… #179

Closed
wants to merge 1 commit into from

Conversation

dolfje
Copy link
Contributor

@dolfje dolfje commented Nov 9, 2021

Description

The selectors are sometimes cryptic and could break with adaptations in the DOM layout. Thus I use a custom selector (see other pull request). But the couldn't find a proper selector to use with typing in a field. Thus I made it possible that no selector is used and the function page.keyboard.type('text') is used. When testing I first click on the label and then type. So the duplicate selector isn't needed. I created an option to use the page.keyboard.type(). It is still defaulted to the page.type() function.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Internal testing

Checklist:

  • My code follows the style guidelines of this project. npm run lint passes with no errors.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. npm run test passes with no errors.

@auto-assign auto-assign bot requested a review from ianaya89 November 9, 2021 17:31
@ianaya89 ianaya89 added the 🔎 under review Under review process label Nov 9, 2021
@ianaya89
Copy link
Contributor

#232

@ianaya89 ianaya89 closed this Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔎 under review Under review process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants