Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cd] Guard cd-circt PR on llvm-firtool publish to Maven #4330

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

jackkoenig
Copy link
Contributor

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash

Release Notes

Now CIRCT bumping CD will wait for the repackaging of firtool as a Maven dependency for use with firtool-resolver.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Internal Internal change, does not affect users, will be included in release notes label Aug 6, 2024
@jackkoenig jackkoenig requested a review from seldridge August 6, 2024 17:20
@jackkoenig jackkoenig enabled auto-merge (squash) August 6, 2024 18:21
@jackkoenig jackkoenig merged commit e6df4cf into main Aug 6, 2024
15 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/cd-firtool-wait-for-maven branch August 6, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants