Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boxstarter -RebootCodes Parameter is not consistent #389

Closed
mwallner opened this issue Mar 20, 2019 · 0 comments
Closed

Boxstarter -RebootCodes Parameter is not consistent #389

mwallner opened this issue Mar 20, 2019 · 0 comments
Assignees
@mwallner
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Milestone
v2.13.0

Comments

@mwallner
Copy link
Member

Boxstarter's Chocolatey command wrappers provide a parameter called -RebootCodes, this can be found in the current Boxstarter tests (i.e. here).

I wanted to use this feature in my generic Boxstarter bootstrapper files, however there are several small bugs/inconsistencies that basically render this unusable in the current state.

To me it seems that

  • the parameter -RebootCodes is actually not evaluted
  • boxstarter behaves differently (concerning at which point of time a reboot will be triggered) when installing via BoxstarterShell, Boxstarter - Module or Boxstarter wrapper (BoxStarter.bat)
@mwallner mwallner mentioned this issue Mar 20, 2019
Merged
@mwallner mwallner self-assigned this Mar 20, 2019
@mwallner mwallner added the 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue label Mar 20, 2019
pauby added a commit that referenced this issue Jul 13, 2019
@pauby
(GH-389) fix RebootCodes option for cinst wrapper (#385)
1fc555c 
(GH-389) fix RebootCodes option for cinst wrapper
@pauby pauby added 4 - Done Code has been added to the repository, and has been reviewed by a team member Bug Issues where something has happened which was not expected or intended and removed 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Jul 13, 2019
@pauby pauby added this to the v2.13.0 milestone Jul 13, 2019
@pauby pauby closed this as completed Jul 13, 2019
@pauby pauby changed the title Boxstarter Package Parameter RebootCodes not evaluted consistently Boxstarter -RebootCodes Parameter is not consistent Oct 19, 2020
@pauby pauby added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwallner mwallner

Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
v2.13.0
Development

No branches or pull requests
2 participants
@mwallner @pauby