pr/christarazi/expand batch testing #1242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
christarazi
commented
Nov 29, 2023
christarazi
commented
- Add unit test for batch lookup with chunking
- Clarify BatchLookup() API
- Additional test for batch lookups
Provide an example of how to use the batch lookup API when chunking, i.e. when the buffer is smaller than the full map. Signed-off-by: Chris Tarazi <[email protected]>
In the kernel documentation for `BPF_MAP_LOOKUP_BATCH`, it explains the semantics of `prevKey`.[1] In this code, the API semantics were not clear which can lead to confusion for users. This commit clarifies the API for BatchLookup() to align closer to the official kernel documentation for `BPF_MAP_LOOKUP_BATCH`. [1]: https://elixir.bootlin.com/linux/v6.6/source/include/uapi/linux/bpf.h#L615 Signed-off-by: Chris Tarazi <[email protected]>
Attempt at more thoroughly testing the batch lookups while deleting / adding elements to the map to assert on the proper iteration of the map. Signed-off-by: Chris Tarazi <[email protected]>
|
Closing this since #1223 went in with better tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.