pin: fix a bunch of fd leaks in tests #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new pin package didn't import fdtrace.TestMain until now, which is why the leaks went by unnoticed. Signed-off-by: Lorenz Bauer <[email protected]>
|
It's very easy to accidentally leak objects when using WalkDir, and kind of awkward to do the right thing (because obj can be nil?) This is why https://pkg.go.dev/github.com/cilium/ebpf/btf#HandleIterator.Take exists for handles. It might be good to do another pass over this API. |
|
Mmmh I'm slightly confused now, this it the typical use we have in Tetragon:
Maybe having an example in the doc would make thing more clear? |
|
Timo pointed out that an issue is probably a better place for this: #1652 |
|
I knew I forgot something. Thanks for the patch! Let's continue the conversation in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new pin package didn't import fdtrace.TestMain until now, which is why the leaks went by unnoticed.