Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsPinned() to RawLink #817

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

boratanrikulu
Copy link
Contributor

Map and Prog have IsPinned() func but RawLink doesn't have it. I added IsPinned() to RawLink. Also seems Unpin method of Rawlink doesn't have a test, I added it too.

Copy link
Collaborator

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Some nits, but otherwise good to go.

@boratanrikulu boratanrikulu force-pushed the feature/link_ispin_func branch from 57f842e to 07255bc Compare October 21, 2022 17:24
@boratanrikulu
Copy link
Contributor Author

@lmb, thank you for the review. I made updates

Copy link
Collaborator

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ti-mo ti-mo merged commit 2a44f1e into cilium:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants