Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up University of York third-party styles #7426

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

adunning
Copy link
Contributor

@adunning adunning commented Feb 4, 2025

Delete outdated University of York styles that do not materially modify other style guides. The updated pages at https://subjectguides.york.ac.uk/referencing-style-guides suggest that these are meant to make these styles easier to use, and not to create alternative definitions. For example, their MLA page currently points students to the 9th edition rather than the 8th edition defined here.

Delete outdated University of York styles that do not materially modify other style guides. The updated pages at <https://subjectguides.york.ac.uk/referencing-style-guides> suggest that these are meant to make these styles easier to use, and not to create alternative definitions. For example, their MLA page currently points students to the 9th edition rather than the 8th edition defined here.
Copy link

github-actions bot commented Feb 4, 2025

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Feb 4, 2025

😟 There are some issues with your submission.

1 test failed

history-australia: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "university-of-york-chicago"

Please check the test report for details.

Journal reference guide specifies Chicago 18th.
Copy link

github-actions bot commented Feb 4, 2025

😃 Your submission passed all our automated tests.

Copy link

github-actions bot commented Feb 4, 2025

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

dependent/history-australia.csl (rendering failure)

Copy link

github-actions bot commented Feb 4, 2025

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

dependent/history-australia.csl (rendering failure)

Copy link

github-actions bot commented Feb 6, 2025

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

dependent/history-australia.csl (rendering failure)

@adam3smith
Copy link
Member

These were originally created 8 years ago in #3053 and they explicitly requested separate styles. Wondering if @AVWoman is still around at York to speak to this (or have you talked to anyone at York by chance @adunning ?)

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Feb 23, 2025
@AVWoman
Copy link
Contributor

AVWoman commented Feb 24, 2025

As it happens we're just looking at these. At some point in the summer we do essentially want to 'get rid' of the duplicate styles and just retain the three Harvard ones. Our thinking was to change the dupes to independent-parent 'redirects', as we're conscious that people are still using the styles and we were keen to avoid things breaking anywhere. But if that's not the best approach then any advice would be gratefully received!

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants