Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review corrections to Paste From Word Image merge task #1227

Merged
merged 4 commits into from
Nov 27, 2017
Merged

Conversation

mlewand
Copy link
Contributor

@mlewand mlewand commented Nov 24, 2017

What is the purpose of this pull request?

Other, review corrections

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

In this PR I have added fixes for all of my review suggestions gave to #1214.

Please review them, and merge to your branch if you're good with it.

Then set #1214 back to a review and I think we're done 🙂

@mlewand mlewand requested a review from msamsel November 24, 2017 21:52
Copy link
Contributor

@msamsel msamsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msamsel msamsel merged commit 06ba63d into t/662-3210 Nov 27, 2017
@msamsel msamsel deleted the t/662-3210b branch November 27, 2017 08:42
@msamsel msamsel restored the t/662-3210b branch December 15, 2017 11:54
@msamsel msamsel deleted the t/662-3210b branch December 15, 2017 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants