Fixed issue with invalid commands state refresh #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
added
the
review:easy
msamsel
suggested changes
Aug 14, 2018
tests/core/selection/editor.js
Outdated
| @@ -149,6 +149,14 @@ bender.test( { | |||
| }, 200 ); | |||
| }, | |||
|
|
|||
| // (#2276) | |||
| 'test "selectionCheck" fires properly': function() { | |||
| testSelectionCheck( this.editors.editor, 'touchstart', 'Fire touchstart.' ); | |||
There was a problem hiding this comment.
Assert message is used as a comment instead of giving reason why assert failed. In error situation you will get message "Fire touchstart" what might be confusing for the user.
| @bender-ui: collapsed | ||
| @bender-ckeditor-plugins: wysiwygarea, link, toolbar | ||
|
|
||
| 1. Set cursor position inside a link. |
There was a problem hiding this comment.
Description is superficial. As a reader I don't know where to focus my attention, especially in builded editor, where all plugins will be loaded. Maybe you could use something like:
Pay attention to
unlinkbutton status in following situations:
- Cursor position inside link.
- (...)
tests/core/selection/editor.js
Outdated
| @@ -149,6 +149,14 @@ bender.test( { | |||
| }, 200 ); | |||
| }, | |||
|
|
|||
| // (#2276) | |||
| 'test "selectionCheck" fires properly': function() { | |||
There was a problem hiding this comment.
"fires properly" seems to be too general description. WDYT about "fires for: mouse, key and touch events"
|
I've rebase it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
A selection wasn't refreshed for touch events and in the result, commands weren't correctly refreshed on iOS. I added appropriate event listeners for
selection.Note: Unit and manual tests are enabled on each browser for simplicity and future changes.
Closes #2276