Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional class identifying expandable buttons and improved styling #2515

Merged
merged 12 commits into from
Oct 26, 2018

Conversation

jacekbogdanski
Copy link
Member

What is the purpose of this pull request?

New feature

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

To keep the same toolbar sizing added an additional CSS class allowing us to identify expandable buttons. More at #2483

Closes #2483

@Comandeer Comandeer self-requested a review October 25, 2018 11:08
@Comandeer Comandeer self-assigned this Oct 25, 2018
@Comandeer Comandeer self-assigned this Oct 25, 2018
Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Disable" button in manual tests does not work in IE8 due to the use of addEventListener. Besides that, LGTM.

Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Comandeer Comandeer merged commit 00b65f4 into major Oct 26, 2018
@CKEditorBot CKEditorBot deleted the t/2483 branch October 26, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants