Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for: Sublist order is reversed when higher level list is removed #2738

Merged
merged 10 commits into from
Jan 28, 2019
Merged

Fix for: Sublist order is reversed when higher level list is removed #2738

merged 10 commits into from
Jan 28, 2019

Conversation

engineering-this
Copy link
Contributor

@engineering-this engineering-this commented Jan 9, 2019 •
edited by AnnaTomanek
Loading

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

Using last added child (list) item as refNode in mergeChildren helper.

Closes #2721, closes #487.

@Comandeer Comandeer self-requested a review January 17, 2019 08:04
@Comandeer Comandeer self-assigned this Jan 17, 2019
@Comandeer Comandeer self-assigned this Jan 17, 2019
Comandeer
Comandeer requested changes Jan 17, 2019
View reviewed changes
Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In IEs the structure of the list after deleting the $ element is incorrect: ol > li > ol > ol > li. It occurs only in manual test.

@engineering-this engineering-this self-assigned this Jan 22, 2019
@engineering-this engineering-this mentioned this pull request Jan 22, 2019
Open
@engineering-this
Copy link
Contributor Author

engineering-this commented Jan 22, 2019 •
edited
Loading

In IEs the structure of the list after deleting the $ element is incorrect: ol > li > ol > ol > li. It occurs only in manual test.

This is an IE upstream issue. Fixing this might be problematic, as removing text followed by <span> or element with display:inline doesn't produce this issue, but there are lots of possibilities, like what would happen when there is position:absolute albo some pseudo elements, etc.?

I've extracted it as a feature request: #2774

@engineering-this engineering-this requested review from Comandeer and removed request for Comandeer January 22, 2019 09:17
@Comandeer Comandeer self-assigned this Jan 25, 2019
Comandeer
Comandeer approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Comandeer Comandeer merged commit 41bf2f7 into master Jan 28, 2019
@CKEditorBot CKEditorBot deleted the t/2721 branch January 28, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Comandeer Comandeer Comandeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engineering-this @Comandeer