Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect defaults for colorbutton config variables #4196

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Conversation

Comandeer
Copy link
Member

What is the purpose of this pull request?

Docs fix

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

* [#3693](https://github.com/ckeditor/ckeditor4/issues/3693): Fixed: incorrect default values for several [Color Button](https://ckeditor.com/cke4/addon/colorbutton) config variables.

What changes did you make?

I've just removed "see source" placeholder and it seems that Umberto took care of it.

Which issues does your PR resolve?

Closes #3693.

@Dumluregn Dumluregn self-assigned this Aug 11, 2020
@Dumluregn Dumluregn self-requested a review August 11, 2020 08:56
Copy link
Contributor

@Dumluregn Dumluregn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wondered if we can format these values anyhow, but I see that Umberto removes all excessive whitespaces, so we can't do anything more here.

@Dumluregn Dumluregn merged commit c4a47ec into master Aug 11, 2020
@Dumluregn Dumluregn deleted the t/3693 branch August 11, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants