Enter modifies only first cell

CHANGES.md

@@ -9,6 +9,7 @@ New Features:
 
 Fixed Issues:
 
+* [#415](https://github.com/ckeditor/ckeditor-dev/issues/415): Fixed: [Firefox] Enter key breaks table structure when pressed in a table selection.
 * [#457](https://github.com/ckeditor/ckeditor-dev/issues/457): Fixed: Error thrown when deleting content from the editor with no selection.
 * [#450](https://github.com/ckeditor/ckeditor-dev/issues/450): Fixed: [`CKEDITOR.filter`](http://docs.ckeditor.com/#!/api/CKEDITOR.filter) incorrectly transforms `margin` CSS property.
 

plugins/tableselection/plugin.js

@@ -853,12 +853,14 @@
 
 			function tableKeyPressListener( evt ) {
 				var selection = editor.getSelection(),
+					// Enter key also produces character, but Firefox doesn't think so (gh#415).
+					isCharKey = evt.data.$.charCode || ( evt.data.getKey() === 13 ),
 					ranges,
 					firstCell,
 					i;
 
 				// We must check if the event really did not produce any character as it's fired for all keys in Gecko.
-				if ( !selection || !selection.isInTable() || !selection.isFake || !evt.data.$.charCode ||
+				if ( !selection || !selection.isInTable() || !selection.isFake || !isCharKey ||
 					evt.data.getKeystroke() & CKEDITOR.CTRL ) {
 					return;
 				}

tests/plugins/tableselection/keyboard.html

@@ -228,3 +228,26 @@
 	</tbody>
 </table>
 </textarea>
+
+<textarea id="enterKey">
+<table>
+	<tr>
+		<td>a</td>
+		<td>b</td>
+		<td>c</td>
+		<td>d</td>
+	</tr>
+</table>
+
+=>
+<table>
+	<tbody>
+		<tr>
+			<td>^&nbsp;</td>
+			<td>&nbsp;</td>
+			<td>&nbsp;</td>
+			<td>&nbsp;</td>
+		</tr>
+	</tbody>
+</table>
+</textarea>

tests/plugins/tableselection/keyboard.js

@@ -170,6 +170,19 @@
 				} );
 				keyTools.key.keyEvent( keyTools.key.keyCodesEnum.BACKSPACE );
 
+				bender.assert.beautified.html( expected, bot.htmlWithSelection() );
+			} );
+		},
+
+		// #415
+		'test enter key': function( editor, bot ) {
+			bender.tools.testInputOut( 'enterKey', function( source, expected ) {
+				bender.tools.setHtmlWithSelection( editor, source );
+
+				editor.getSelection().selectRanges( getRangesForCells( editor, [ 0, 1, 2, 3 ] ) );
+
+				editor.editable().fire( 'keypress', new CKEDITOR.dom.event( { keyCode: 13 } ) );
+
 				bender.assert.beautified.html( expected, bot.htmlWithSelection() );
 			} );
 		}

tests/plugins/tableselection/manual/enterkey.html

@@ -0,0 +1,48 @@
+<div id="editor1">
+	<p>Some text</p>
+
+	<table border="1">
+		<tr>
+			<td>Cell 1.1</td>
+			<td>Cell 1.2</td>
+			<td>Cell 1.3</td>
+			<td>Cell 1.4</td>
+		</tr>
+		<tr>
+			<td>Cell 2.1</td>
+			<td>Cell 2.2</td>
+			<td>Cell 2.3</td>
+			<td>Cell 2.4</td>
+		</tr>
+		<tr>
+			<td>Cell 3.1</td>
+			<td>Cell 3.2</td>
+			<td>Cell 3.3</td>
+			<td>Cell 3.4</td>
+		</tr>
+		<tr>
+			<td>Cell 4.1</td>
+			<td>Cell 4.2</td>
+			<td>Cell 4.3</td>
+			<td>Cell 4.4</td>
+		</tr>
+		<tr>
+			<td>Cell 5.1</td>
+			<td>Cell 5.2</td>
+			<td>Cell 5.3</td>
+			<td>Cell 5.4</td>
+		</tr>
+	</table>
+
+	<p>Some text</p>
+</div>
+
+<script>
+	if ( !CKEDITOR.env.gecko ) {
+		bender.ignore();
+	}
+
+	CKEDITOR.replace( 'editor1', {
+		autoGrow_onStartup: true
+	} );
+</script>

tests/plugins/tableselection/manual/enterkey.md

@@ -0,0 +1,13 @@
+@bender-ui: collapsed
+@bender-tags: tc, gh415, 4.7.1
+@bender-ckeditor-plugins: wysiwygarea, toolbar, tableselection, sourcearea, elementspath, undo
+
+**Procedure:**
+
+1. Select two or more table cells.
+2. Press <kbd>Enter</kbd>.
+
+**Expected result:**
+
+* Visual selection is discarded.
+* The new line is typed into the first selected table cell and collapsed selection is placed after it.