Added default value to useComputedState in the CKEDITOR config object

[shabab477]

Issue #4918

What is the purpose of this pull request?

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

• Unit tests
• Manual tests

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

• PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

Skipped

What changes did you make?

Added default config value for useComputedState

Which issues does your PR resolve?

Closes #4918.

[Comandeer]

Hi, @shabab477! Thanks for your contribution.

The change looks good. However, we require that every change be accompanied by the test. Could I ask you to add a test to /tests/config directory? The test can be simple, e.g. creating the editor and then checking its editor.config.useComputedState value.

It'd be also good to remove the logic connected to treating undefined config.useComputedState variable the same way as the one set to true (see the issue's description for more info). Could you add it as a part of this PR?

[shabab477]

Alright 👍

[Comandeer]

Thanks for your fixes!

The test looks good. Could I ask you to add a similar one also to tests/core/config/themed_ui.js?

There are also several other places in plugins where the trick similar to the one with undefined is used, e.g.

ckeditor4/plugins/bidi/plugin.js

Line 83 in 6111ac2

var useComputedState = ( 'useComputedState' in editor.config ) ? editor.config.useComputedState : 1;

. Could I ask you to also fix them?

[Comandeer]

The indentation here seems to be incorrect:

Suggested change

	*
	* @since 3.4.0
	* @cfg {Boolean} [useComputedState=true]
	*/
	*
	* @since 3.4.0
	* @cfg {Boolean} [useComputedState=true]
	*/

[shabab477]

Done

[Comandeer]

There is no need to compare variable's value to true, asserting its value is enough in this case:

Suggested change

	assert.isTrue( this.editor.config.useComputedState === true, 'config.useComputedState should return true as default' );
	assert.isTrue( this.editor.config.useComputedState, 'config.useComputedState should return true as default' );

[shabab477]

Done

[shabab477]

Fixed usages of useComputedState workarounds in the code for plugins:

• justify
• list
• bidi

[Comandeer]

LGTM! Thanks once again for your contribution.