[#834] Fix radio button selection problem when used in IE browser. #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comandeer
requested changes
Sep 11, 2017
tests/plugins/forms/radio.js
Outdated
| var bot = this.editorBot; | ||
|
|
||
| bot.setHtmlWithSelection( '[<input checked="checked" name="name" required="required" type="radio" value="value" />]' ); | ||
| if ( CKEDITOR.env.ie ) { | ||
| bot.setHtmlWithSelection( '[<input checked="checked" name="name" required="required" type="radio" />]' ); |
There was a problem hiding this comment.
Why IE got different markup, without [value]? Can't it got the same markup and then just overwrite the attribute?
| </div> | ||
|
|
||
| <script> | ||
| CKEDITOR.replace( 'editor' ); |
There was a problem hiding this comment.
Please add ignore as it's only for IEs.
Comandeer
approved these changes
Sep 12, 2017
- ignoring manual test on non-IE browsers - changing tag of target version to 4.8.0 - rebase and change target branch from master to major - little update to manual test description - rearranging unit test - IE gets dedicated assertion instead of having dedicated markup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
Close #834