Curves interfaces consistency #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also: scipr-lab/libff#35 |
Remove unnecessary extra pointer in fill_coord
dtebbs
approved these changes
Apr 3, 2020
|
Will wait for the build to pass, and will point libff submodules to this branch on other projects to make sure that nothing breaks. Will merge after that. |
|
Merging this PR as I have updated the submodules on other repos and did the appropriate changes in libsnark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interfaces of the various curves was not consistent which led errors if we tried to switch curves.
For instance, the coordinates were represented as private attributes
X_, Y_, Z_in the MNT curves, which could be accessed via the gettersX(), Y(), Z().For the alt_bn128 curve however, these attributes were public and named
X, Y, Z.This inconsistency in the interface requires to change the code base of a project if one switches the curve.
See: https://github.com/clearmatics/zeth/pull/181/files for an example of project that is affected by this.
This PR fixes the above issue.