-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency auditing to pipelines #460
Conversation
eb61297
to
4f3ee10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Can you add the audit task to the staging and prod pipelines?
ci/tasks/pip-audit.sh
Outdated
|
||
set -euo pipefail | ||
|
||
pip install -r requirements-dev.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the audit you can install just pip-audit
to speed this up a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Still works and it's definitely lighter.
I've added it to |
@svenaas for staging/prod (which both run off |
@drewbo How's this latest commit look? I changed the notification text a little as well. |
c33ba6b
to
c947af3
Compare
Part of #458
Changes proposed in this pull request:
pip-audit.sh
script and newaudit-dependencies
tasks which run it in the CI pipelines.security considerations
None. This introduces a new check to help ensure that out-of-date dependencies get resolved.