Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jobs.js #4677

Closed
1 task
drewbo opened this issue Nov 21, 2024 · 1 comment · Fixed by #4679
Closed
1 task

Remove jobs.js #4677

drewbo opened this issue Nov 21, 2024 · 1 comment · Fixed by #4679
Assignees

Comments

@drewbo
Copy link
Contributor

drewbo commented Nov 21, 2024

The file at api/jobs.js runs scheduled jobs but there are two issues with this file/pattern:

  • We run all other scheduled jobs via our queue workers
  • This only runs one job, an audit which removes users from a site using SiteUsers, a deprecated access pattern

Acceptance Criteria

  • Remove this file, job, and associated dependencies
@drewbo
Copy link
Contributor Author

drewbo commented Nov 22, 2024

Noting, per Chesterton's Fence, that we previously used this job to audit sites, ensuring that people without Github write access were removed from the SiteUsers, a now (semi-)deprecated access pattern. Searching the logs, the job itself has been running daily as scheduled but hasn't removed a user in at least one year.

drewbo added a commit that referenced this issue Nov 22, 2024
@drewbo drewbo mentioned this issue Nov 22, 2024
@drewbo drewbo self-assigned this Nov 22, 2024
drewbo added a commit that referenced this issue Nov 22, 2024
drewbo added a commit that referenced this issue Nov 22, 2024
drewbo added a commit that referenced this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant