-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat skeleton build task #4248
Feat skeleton build task #4248
Conversation
eb74058
to
de39abf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looking for your thoughts on different options for kicking off the build tasks. Once we test out running jobs on a worker, cf task, or third party service, we'll have a better idea of how we want the job processor interface to function. We may want to lean more on bullmq's API for managing the job lifecycle but this is a great start. Awesome work.
c952d3d
to
9c16540
Compare
@apburnes updated in response to your feedback:
|
b70611e
to
bdf1d4e
Compare
@drewbo looks good so far. |
730fa0d
to
777b036
Compare
8ae4684
to
89fc934
Compare
This is ready to go again, in conjunction with cloud-gov/pages-cf-build-tasks#1. It contains API tests but nothing for the CF API call to the tasks endpoint; happy to add that before final review. Also because this is a large feature, I'm available to demo or add more docs as needed. |
89fc934
to
1b2e73b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Changes proposed in this pull request:
Extreme WIP (but functional) PR which implements the following items from the acceptance criteria
I've also added a "hidden admin page" at
/tasks
which shows some build task information. The build task does run code, but currently it's fully encapsulated in the worker, rather than running a CF task. I have a number of problems with the current architecture and would love advice on proceeding:enqueue
(previously existing) andstartBuildTask
(added).security considerations
New non-user enforced endpoint is added for status reporting (uses secret token to validate responses)