Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update deps using json5 #4249 #4257

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Sep 29, 2023

Closes #4249

Changes proposed in this pull request:

  • Updates deps using json5
  • Does not update json5 dependency for nyc code coverage tool. It is a dev dependency and we will look to update the test suite code coverage options in another issue.

security considerations

Updates dependencies

@apburnes apburnes force-pushed the chore-update-deps-4249 branch from 625fe15 to 01eeb87 Compare October 2, 2023 14:58
@apburnes apburnes force-pushed the chore-update-deps-4249 branch from 7f4b143 to 516c8ba Compare October 4, 2023 20:42
@apburnes apburnes requested a review from a team October 4, 2023 20:51
Copy link
Contributor

@drewbo drewbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this also leaves in the json5 dependency from fetch-mock and chaijs but those are also dev dependencies we can cleanup later. Looks good

@apburnes apburnes merged commit 9282d2f into main Oct 4, 2023
@apburnes apburnes deleted the chore-update-deps-4249 branch October 4, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update libraries with older json5 dependencies
2 participants