Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Run db migrations in CI task container with SSL #4354 #4355

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix(ci): Run db migrations in CI task container with SSL #4354 #4355

merged 1 commit into from
Jan 11, 2024
+122 −19

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Jan 10, 2024 •
edited
Loading

Closes #4354

Changes proposed in this pull request:

  • Switches CI task to run the db migrations in the CI container
  • Uses SSL config to run migraitons

security considerations

Runs migrations over SSL with update to PG 15

@apburnes apburnes force-pushed the fix-ci-rework-db-migrations-task branch from 721d205 to 3973006 Compare January 10, 2024 23:28
@apburnes apburnes force-pushed the fix-ci-rework-db-migrations-task branch from 2633dac to 5293be4 Compare January 11, 2024 00:04
@apburnes apburnes requested a review from a team January 11, 2024 00:19
svenaas
svenaas approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@svenaas svenaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray, @apburnes!

@apburnes apburnes merged commit ad7e780 into main Jan 11, 2024
3 checks passed
@apburnes apburnes deleted the fix-ci-rework-db-migrations-task branch January 11, 2024 14:10
@apburnes apburnes mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenaas svenaas svenaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix database migrations in CI
2 participants
@apburnes @svenaas