fuse: Ensure lookup sets st_ino of attributes #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filesystem test utility xfs-tests[1] failed on test generic/007 with the error nametest.16 (8370) lookup, should be inumber 72057594037927972. It can be observed in the kernel that the inode number for the file often switches between the hosts inode number and the fuse assigned one. In the vfs lookup function the out entry inode is set on the top level but does not update attr.st_ino field. Adjust this so that the inode number is correctly set on the attributes. After this change the test generic/007 passes. [1] https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/tree/ Signed-off-by: Champ-Goblem <[email protected]>
Champ-Goblem
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filesystem test utility xfs-tests[1] failed on test generic/007 with the error nametest.16 (8370) lookup, should be inumber 72057594037927972. It can be observed in the kernel that the inode number for the file often switches between the hosts inode number and the fuse assigned one.
In the vfs lookup function the out entry inode is set on the top level but does not update attr.st_ino field. Adjust this so that the inode number is correctly set on the attributes.
After this change the test generic/007 passes.
[1] https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/tree/