Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soname versioning #165

Closed
candrews opened this issue Sep 13, 2019 · 4 comments · Fixed by #1769
Closed

soname versioning #165

candrews opened this issue Sep 13, 2019 · 4 comments · Fixed by #1769

Comments

@candrews
Copy link

Currently, there's just the library file libquiche.so

It would be better if soname versioning was implemented so libquiche.so is a symlink to, for example, the actual library file named libquiche.so.0.0.0
The library should also have DT_SONAME set appropriately.

Could you please implement soname versioning?
@ghedo
Copy link
Member

ghedo commented Sep 13, 2019

Again something that cargo doesn't support rust-lang/cargo#5045

@ghedo
Copy link
Member

ghedo commented Sep 22, 2019 •
edited
Loading

In the cargo ticket above it was suggested to use the cdylib-link-lines crate, which supposedly would set the SONAME in the dynamic library. Though I don't know if it also renames the .so file accordingly.

I'll have a look once I have a bit of time.

@candrews
Copy link
Author

@ghedo here's a reference that may help Quiche implement soname versioning: https://blogs.gentoo.org/lu_zero/2019/07/01/building-crates-so-they-look-like-cabi-libraries/

Thanks again!

@lu-zero
Copy link

lu-zero commented Jun 10, 2020

It evolved to cargo-c, you might find it useful.

@ghedo ghedo mentioned this issue Jul 22, 2020
Closed
@ghedo ghedo mentioned this issue Jan 26, 2021
Closed
junhochoi added a commit to junhochoi/quiche that referenced this issue Apr 30, 2024
@junhochoi
Add soname to libquiche.so
c3dc140 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so as follows:

```
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos.

Fixes cloudflare#598
Fixes cloudflare#165
@junhochoi junhochoi mentioned this issue Apr 30, 2024
Merged
junhochoi added a commit to junhochoi/quiche that referenced this issue Apr 30, 2024
@junhochoi
Add soname to libquiche.so
71d06fd 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos.

Fixes cloudflare#598
Fixes cloudflare#165
junhochoi added a commit to junhochoi/quiche that referenced this issue Apr 30, 2024
@junhochoi
Add soname to libquiche.so
f6f3c05 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos.

Fixes cloudflare#598
Fixes cloudflare#165
junhochoi added a commit to junhochoi/quiche that referenced this issue May 8, 2024
@junhochoi
Add soname to libquiche.so
55843a6 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos.

Fixes cloudflare#598
Fixes cloudflare#165
junhochoi added a commit to junhochoi/quiche that referenced this issue May 9, 2024
@junhochoi
Add soname to libquiche.so
69a5a22 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos.

Fixes cloudflare#598
Fixes cloudflare#165
junhochoi added a commit to junhochoi/quiche that referenced this issue May 9, 2024
@junhochoi
Add soname to libquiche.so
d7670bb 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos. It requires `ffi` feature.

Fixes cloudflare#598
Fixes cloudflare#165
junhochoi added a commit to junhochoi/quiche that referenced this issue May 17, 2024
@junhochoi
Add soname to libquiche.so
7e16453 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos.

Fixes cloudflare#598
Fixes cloudflare#165
junhochoi added a commit to junhochoi/quiche that referenced this issue May 21, 2024
@junhochoi
Add soname to libquiche.so
5864aa3 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos.

Fixes cloudflare#598
Fixes cloudflare#165
junhochoi added a commit to junhochoi/quiche that referenced this issue Jun 20, 2024
@junhochoi
Add soname to libquiche.so
cd2fc69 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos. It requires `ffi` feature.

Fixes cloudflare#598
Fixes cloudflare#165
junhochoi added a commit to junhochoi/quiche that referenced this issue Jun 20, 2024
@junhochoi
Add soname to libquiche.so
b2a3c92 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos. It requires `ffi` feature.

Fixes cloudflare#598
Fixes cloudflare#165
junhochoi added a commit to junhochoi/quiche that referenced this issue Jun 20, 2024
@junhochoi
Add soname to libquiche.so
e690019 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos. It requires `ffi` feature.

Fixes cloudflare#598
Fixes cloudflare#165
ghedo pushed a commit to junhochoi/quiche that referenced this issue Jun 25, 2024
@junhochoi @ghedo
Add soname to libquiche.so
4679c56 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos. It requires `ffi` feature.

Fixes cloudflare#598
Fixes cloudflare#165
ghedo pushed a commit that referenced this issue Jun 25, 2024
@junhochoi
build: add soname to libquiche.so
558127f 
Using cdylib-link-lines, add soname to the generated shlibs.

It will add the following to libquiche.so:

```
% readelf -d target/debug/libquiche.so
...
 0x000000000000000e (SONAME)             Library soname: [libquiche.so.0]
```

For linux, *bsd, android, ios and macos. It requires `ffi` feature.

Fixes #598
Fixes #165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add soname to libquiche.so junhochoi/quiche
3 participants
@ghedo @candrews @lu-zero