Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types/defines/ai.d.ts): correct the type of the segments property to be an array #3623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lqm1
Copy link

@Lqm1 Lqm1 commented Feb 27, 2025

Correct the incorrect type of Output in “@cf/openai/whisper-large-v3-turbo”.
I think segments is array.

@Lqm1 Lqm1 requested review from a team as code owners February 27, 2025 15:06
@Lqm1 Lqm1 requested review from ObsidianMinor and fhanau February 27, 2025 15:06
@fhanau
Copy link
Collaborator

fhanau commented Feb 27, 2025

@thatsKevinJain

Copy link

github-actions bot commented Feb 27, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Lqm1
Copy link
Author

Lqm1 commented Feb 27, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 27, 2025
@Lqm1
Copy link
Author

Lqm1 commented Feb 27, 2025

After checking the issue, we found a issue, so we will link it for management purposes.

Closes #3410

@fhanau
Copy link
Collaborator

fhanau commented Feb 27, 2025

@thatsKevinJain can you review this change? Looks like CI is passing, except that generated type definitions need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants