Stop cloudchamber build from trying to push image when build fails

.changeset/chilly-knives-itch.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Fix a bug in cloudchamber build where it would still attempt to push an image if the build failed.

packages/wrangler/src/cloudchamber/build.ts

@@ -1,4 +1,5 @@
 import { spawn } from "child_process";
+import { stat } from "fs/promises";
 import { logRaw } from "@cloudflare/cli";
 import { ImageRegistriesService } from "./client";
 import type { Config } from "../config";
@@ -68,17 +69,20 @@ export async function constructBuildCommand(options: {
 }
 
 // Function for building
-export async function dockerBuild(options: { buildCmd: string }) {
-	const buildCmd = options.buildCmd.split(" ").slice(1);
-	const buildExec = options.buildCmd.split(" ").shift();
-	const child = spawn(String(buildExec), buildCmd, { stdio: "inherit" }).on(
-		"error",
-		(err) => {
-			throw err;
-		}
-	);
-	await new Promise((resolve) => {
-		child.on("close", resolve);
+export async function dockerBuild(options: {
+	buildCmd: string;
+}): Promise<void> {
+	return new Promise((resolve, reject) => {
+		const buildCmd = options.buildCmd.split(" ").slice(1);
+		const buildExec = options.buildCmd.split(" ").shift();
+		const child = spawn(String(buildExec), buildCmd, { stdio: "inherit" });
+		child.on("exit", (code) => {
+			if (code === 0) {
+				resolve();
+			} else {
+				reject(new Error(`Build exited with code: ${code}`));
+			}
+		});
 	});
 }
 
@@ -160,17 +164,33 @@ export function pushYargs(yargs: CommonYargsArgvJSON) {
 		.positional("TAG", { type: "string", demandOption: true });
 }
 
+async function isDir(path: string): Promise<boolean> {
+	const stats = await stat(path);
+	return await stats.isDirectory();
+}
+
 export async function buildCommand(
 	args: StrictYargsOptionsToInterfaceJSON<typeof buildYargs>,
 	_: Config
 ) {
+	try {
+		const dir = await isDir(args.PATH);
+		if (!dir) {
+			logRaw(`PATH must be a directory`);
+			return;
+		}
+	} catch (error) {
+		logRaw(`Error when checking ${args.PATH}: ${error}`);
+		return;
+	}
+
 	try {
 		await constructBuildCommand({
 			imageTag: args.tag,
 			pathToDockerfile: args.PATH,
 			pathToDocker: args.pathToDocker,
 		})
-			.then(async (bc) => dockerBuild({ buildCmd: bc }))
+			.then(async (bc) => await dockerBuild({ buildCmd: bc }))
 			.then(async () => {
 				if (args.push) {
 					await dockerLoginManagedRegistry({
@@ -181,11 +201,7 @@ export async function buildCommand(
 				}
 			});
 	} catch (error) {
-		if (error instanceof Error) {
-			logRaw(error.message);
-		} else {
-			logRaw("An unknown error occurred");
-		}
+		logRaw(error);
 	}
 }