Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encode project names in @cloudflare/vitest-pool-workers #7084

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

penalosa
Copy link
Contributor

Fixes #6954

URL encode project names to support scoped names (e.g. @scoped/durable-objects) when using runInDurableObject()


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by fixtures
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@penalosa penalosa requested a review from a team as a code owner October 24, 2024 10:41
Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 165948f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa added the vitest Relating to the Workers Vitest integration label Oct 24, 2024
@penalosa penalosa changed the title URL encode project names URL encode project names in @cloudflare/vitest-pool-workers Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-wrangler-7084

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7084/npm-package-wrangler-7084

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-wrangler-7084 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-cloudflare-workers-bindings-extension-7084 -O ./cloudflare-workers-bindings-extension.0.0.0-v413d32d11.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v413d32d11.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-create-cloudflare-7084 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-cloudflare-kv-asset-handler-7084

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-miniflare-7084

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-cloudflare-pages-shared-7084

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-cloudflare-unenv-preset-7084

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-cloudflare-vite-plugin-7084

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-cloudflare-vitest-pool-workers-7084

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-cloudflare-workers-editor-shared-7084

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-cloudflare-workers-shared-7084

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13391636244/npm-package-cloudflare-workflows-shared-7084

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.1
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa marked this pull request as draft November 7, 2024 15:54
@edmundhung edmundhung force-pushed the penalosa/vitest-fixes branch from f226333 to c8e2e8e Compare February 17, 2025 19:53
@penalosa penalosa marked this pull request as ready for review February 18, 2025 13:21
@CarmenPopoviciu CarmenPopoviciu merged commit 82a8937 into main Feb 19, 2025
16 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the penalosa/vitest-fixes branch February 19, 2025 11:21
emily-shen pushed a commit that referenced this pull request Feb 20, 2025
* Fix #6954

* fix windows?

* replace chars with underscore

* Create soft-drinks-hug.md

* Update soft-drinks-hug.md

---------

Co-authored-by: Edmund Hung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vitest Relating to the Workers Vitest integration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Vitest: runInDurableObject() fails if package.json contains a namespace (e.g. @repo/my-worker)
3 participants