Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workers Assets metafiles in asset-worker and wrangler dev #8279

Draft
wants to merge 1 commit into
base: metafiles
Choose a base branch
from

Conversation

GregBrimble
Copy link
Contributor

@GregBrimble GregBrimble commented Feb 27, 2025

Fixes WC-3249 and WC-3246.

Implements support for Workers Assets metafiles (_headers and _redirects) in the production asset-worker and in wrangler dev.

Also fixes a bug where .assetsignore was not being applied in wrangler dev.

  • watch mode
  • check if I'm passing in line numbers?
  • tests
  • changeset
  • vite dev
  • idk about putting everything into @cloudflare/workers-shared
  • check with @penalosa about the configcontroller watcher
  • think about what to do with unstable_canFetch and the like
  • lightweight patch config update?

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: we'll do it after the API support has landed

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 85c4bc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GregBrimble GregBrimble changed the title Workers Assets metafiles in production and wrangler dev Workers Assets metafiles in asset-worker and wrangler dev Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant