feat(miniflare): Add assets Proxy Worker skeleton in miniflare #8288
+62
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb06789 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CarmenPopoviciu
force-pushed
the
carmen/proxy-worker-skeleton
branch
3 times, most recently
from
bc52526 to
e5d2dfe
Compare
This commit implements a very basic Proxy Worker skeleton, and wires it in the "pipeline" miniflare creates for assets. This Worker will be incrementally worked on, but for now, the current implementation will forward all incoming requests to the Router Worker, thus leaving the current assets behaviour in local dev, the same. Fixes DEVX-1641, DEVX-1642
CarmenPopoviciu
force-pushed
the
carmen/proxy-worker-skeleton
branch
from
e5d2dfe to
fb06789
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-wrangler-8288You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8288/npm-package-wrangler-8288Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-wrangler-8288 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-cloudflare-workers-bindings-extension-8288 -O ./cloudflare-workers-bindings-extension.0.0.0-vdf3dace04.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vdf3dace04.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-create-cloudflare-8288 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-cloudflare-kv-asset-handler-8288miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-miniflare-8288@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-cloudflare-pages-shared-8288@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-cloudflare-unenv-preset-8288@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-cloudflare-vite-plugin-8288@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-cloudflare-vitest-pool-workers-8288@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-cloudflare-workers-editor-shared-8288@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-cloudflare-workers-shared-8288@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13571423289/npm-package-cloudflare-workflows-shared-8288Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a very basic Proxy Worker skeleton, and wires it in the "pipeline" miniflare creates for assets. This Worker will be incrementally worked on, but for now, the current implementation will forward all incoming requests to the Router Worker, thus leaving the current assets behaviour in local dev, unchanged.
TLDR 👇
Why are we doing this? Because we expect the proxy Worker code to be quite involved, so we don't want to worry at that point whether the wiring works properly or not. We just want to focus on that Worker code
Fixes DEVX-1641, DEVX-1642